Draft: add gRPC extensions an configuration class #542
Conversation
MathoMathiasCamara
changed the title
There was a problem hiding this comment.
I'm questioning whether it is truly necessary for MORYX to provide these kinds of wrapper functions. We had similar functionality in the past but removed most of it, primarily because wrapping tends to obscure important details and limits the ability to apply custom adjustments. This can lead to reduced transparency and flexibility in implementation.
| /// <summary> | ||
| /// Whether to use TLS or not | ||
| /// </summary> | ||
| [Description("Wheter to use TLS or not"), DefaultValue(true)] |
There was a problem hiding this comment.
DefaultValue = true is not a good idea because you never cannot set it to false
| <PackageReference Include="Grpc.Net.Client" /> | ||
| <PackageReference Include="Grpc.Core" /> |
There was a problem hiding this comment.
MORYX does not have any package references except dotnet and Newtonsoft (should be replaced by System.Text.Json later). If this should really part of the MORYX-Framework, this should be part of a separate package to keep the dependencies as minimal as possible
| <PackageReference Update="Grpc.Core" Version="2.46.6" /> | ||
| <PackageReference Update="Grpc.Net.Client" Version="2.71.0" /> |
There was a problem hiding this comment.
Is 2.46/2.71 really necessary, or is 2.0.0 also enough? Let the developers decide which version is necessary.
2 participants
Given that we are using gRPC in more than one project/repos. @seveneleven proposed to have a package for the common components to avoid duplication in future project.