UseStatements::splitImportUseStatement: improve test consistency #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "parse error due to reserved keyword as alias" tests for `use .... as function` and `use ... as class` already showed what the _real_ expected output should be. The test for `use ... as const` did not, as the code after it did not contain a semi-colon. As part of the underlying issue for this code sample (the semi-colon being tokenized as `T_STRING`) has been fixed in PHPCS 3.7.0, this now meant that the test would give a different result in PHPCS 3.7.0+ vs PHPCS < 3.7.0. As use statements are generally at the top of a file, it would be extraordinarily rare for code like that to ever occur in real life. On top of that, this is a parse error. With both of those things in mind, just fixing the test code to allow the test to return consistent results PHPCS cross-version feels like the appropriate fix.
jrfnl
deleted the
feature/usestatements-make-test-for-splitting-more-consistent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "parse error due to reserved keyword as alias" tests for
use .... as functionanduse ... as classalready showed what the real expected output should be.The test for
use ... as constdid not, as the code after it did not contain a semi-colon.As part of the underlying issue for this code sample (the semi-colon being tokenized as
T_STRING) has been fixed in PHPCS 3.7.0, this now meant that the test would give a different result in PHPCS 3.7.0+ vs PHPCS < 3.7.0.As use statements are generally at the top of a file, it would be extraordinarily rare for code like that to ever occur in real life. On top of that, this is a parse error.
With both of those things in mind, just fixing the test code to allow the test to return consistent results PHPCS cross-version feels like the appropriate fix.