-
Notifications
You must be signed in to change notification settings - Fork 5.9k
【CUDA Kernel No.74、75】lookup_table、lookup_table_grad算子Kernel修复 -part #75645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
| DenseTensor *out); | ||
|
|
||
| template <typename T, typename Context> | ||
| void LookupTableKernel(const Context &dev_ctx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpu 和 gpu kernel名称不同的,在gpu目录下新增头文件,其中仅声明gpu kernel即可。
| SelectedRows *w_grad); | ||
|
|
||
| template <typename T, typename Context> | ||
| void LookupTableGradKernel(const Context &dev_ctx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpu的kernel声明应当去掉,并且此文件应当放在gpu目录中
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/phi/kernels/lookup_table_grad_kernel.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要此头文件
|
请修复codestyle |
|
/re-run all-failed |
|
/re-run all-failed |
| ' | ||
| HeaderFilterRegex: '^(paddle/(?!cinn)).*$' | ||
| AnalyzeTemporaryDtors: false | ||
| WarningsAsErrors: '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请不要修改此文件
|
/re-run all-failed |
|
/re-run all-failed |
YqGe585
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Performance Optimization
PR Types
Bug fixes
Description
Add paddle/phi/kernels/lookup_table_kernel.h和paddle/phi/kernels/lookup_table_grad_kernel.h