Skip to content

Conversation

@Le-soleile
Copy link
Contributor

@Le-soleile Le-soleile commented Oct 1, 2025

PR Category

Performance Optimization

PR Types

Bug fixes

Description

Add paddle/phi/kernels/lookup_table_kernel.h和paddle/phi/kernels/lookup_table_grad_kernel.h

@paddle-bot
Copy link

paddle-bot bot commented Oct 1, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 1, 2025
@Le-soleile Le-soleile changed the title 【CUDA Kernel No.75】lookup_table算子Kernel修复 -part 【CUDA Kernel No.74、75】lookup_table、lookup_table_grad算子Kernel修复 -part Oct 1, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 9, 2025
DenseTensor *out);

template <typename T, typename Context>
void LookupTableKernel(const Context &dev_ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpu 和 gpu kernel名称不同的,在gpu目录下新增头文件,其中仅声明gpu kernel即可。

SelectedRows *w_grad);

template <typename T, typename Context>
void LookupTableGradKernel(const Context &dev_ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpu的kernel声明应当去掉,并且此文件应当放在gpu目录中

// See the License for the specific language governing permissions and
// limitations under the License.

#include "paddle/phi/kernels/lookup_table_grad_kernel.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要此头文件

@YqGe585
Copy link
Contributor

YqGe585 commented Oct 17, 2025

请修复codestyle

@Le-soleile
Copy link
Contributor Author

/re-run all-failed

@Le-soleile
Copy link
Contributor Author

/re-run all-failed

'
HeaderFilterRegex: '^(paddle/(?!cinn)).*$'
AnalyzeTemporaryDtors: false
WarningsAsErrors: '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请不要修改此文件

This reverts commit 644eacc.
This reverts commit f7bf793.
This reverts commit cbba545.
@Le-soleile
Copy link
Contributor Author

/re-run all-failed

@Le-soleile
Copy link
Contributor Author

/re-run all-failed

Copy link
Contributor

@YqGe585 YqGe585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 12737a6 into PaddlePaddle:develop Oct 31, 2025
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants