Skip to content

Conversation

@algorithm1832
Copy link
Contributor

PR Category

Custom Device

PR Types

Improvements

Description

  • Include index_add_grad_kernel.h to replace .cu file include
  • Fix missing kernel_registry includes
  • Remove duplicate file in iluvatar_gpu's cmakelists

ℹ️The .h file already exists in the Paddle repo: paddle/phi/kernels/index_add_grad_kernel.h

ℹ️The index_add_grad_kernel.cu file has been included in iluvatar_gpu's cmakelists starting from line 269.

file(
  GLOB
  CUDA_SRCS2
  ...
  ${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/index_add_grad_kernel.cu
  ...
)
set(CUDA_SRCS ${CUDA_SRCS1} ${CUDA_SRCS2})
list(REMOVE_DUPLICATES CUDA_SRCS1)

ℹ️The index_add_grad_kernel.cu file has been included in metax_gpu's cmakelists starting from line 107.

file(
  GLOB
  CUDA_SRCS
  ...
  ${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/index_add_grad_kernel.cu
  ...
)

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2025

Thanks for your contribution!

Copy link
Collaborator

@YqGe585 YqGe585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YqGe585 YqGe585 merged commit cbf0875 into PaddlePaddle:develop Oct 17, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants