Skip to content

Conversation

tanpv
Copy link

@tanpv tanpv commented Oct 17, 2018

Please check if the PR fulfills these requirements

  • [DONE ] The commit message follows our Submission guidelines
  • [DONE] Tests for the changes have been added (for bug fixes / features)
  • [DONE ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Optimize for cleaner verifyTransfer algorithm

What is the current behavior?

What is the new behavior?

  • Remove "alreadyWithdrawn" from "LockUp" struct
  • Add function "_getInvestorCurrentLockUpAmount"
  • Change logic inside "verifyTransfer"

Does this PR introduce a breaking change?

  • No breaking change
  • All tests are run passed

Any Other information:

@tanpv tanpv changed the title Development 1.5.0 Optimize Volume Lockup Transfer Manager Oct 18, 2018
@satyamakgec
Copy link
Contributor

Thanks, @tanpv for your work but we optimize in #409 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants