Polymath Core 2.0 Release #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dividend name
CLI: Gas limit for estimation
remove Log prefix from the oracles contract
CLI dividend name
# Conflicts: # contracts/modules/Checkpoint/ERC20DividendCheckpointFactory.sol # contracts/modules/Checkpoint/EtherDividendCheckpointFactory.sol # contracts/tokens/SecurityToken.sol
# Conflicts: # contracts/modules/Checkpoint/ERC20DividendCheckpointFactory.sol # contracts/modules/Checkpoint/EtherDividendCheckpointFactory.sol # contracts/tokens/SecurityToken.sol
* change in the permission doc * change in the permission of the checkpoint module * simple fix * add one more permission to checkpoint * CLI - premission list updated
…Network/polymath-core into private/fede/cli/removeDelegate
…elegate removeDelegate() function on CLI
* general fixes * remove view
* Make `changeHolderPercentage` in PercentageTM a permissioned * Add delegate l_percentage_transfer_manager.js * Remove redundant getters: fixed review comments * Update test/l_percentage_transfer_manager.js
Optimized verifyTransfer
* ModuleFactory var visibility changed to internal * remove the redundant getters * fix test cases
* merged the fix to ST from PR 327 * typo fix
* finished interfaces * finished devidencChecipoint.sol * finished checkpoint and burn modules * finished grammar checks and err msg * fix iModuleFactry grammar * grammar update Co-Authored-By: comeonbuddy <[email protected]> * grammar update Co-Authored-By: comeonbuddy <[email protected]> * grammar updatet Co-Authored-By: comeonbuddy <[email protected]> * grammar updates Co-Authored-By: comeonbuddy <[email protected]> * grammar updates Co-Authored-By: comeonbuddy <[email protected]> * grammar fixes * grammer fixes Co-Authored-By: comeonbuddy <[email protected]> * fix issue * fixed test
* Fixed pruneInvestors * Minor bug fix in tokenlib * Added a test case for pruning * general fixes * remove view * ST optimizations * Get rid of pruning logic * Revert "Get rid of pruning logic" This reverts commit 63f12bc. * Remove pruning and add convenience functions * Update CHANGELOG * Add new functions to ISecurityToken interface * Update CHANGELOG.md * Added missing natspec comments * Added natspec comments to interface * Added test case * Fix typo
* WIP * More WIP * Use a public function * Comment out to * Wip * Add some test cases and fix * Fix ordering. * More test cases * Add natspec commitments * Remove some revert messages * Follow best practice for function modifiers * Change timing in test cases * use the createInstance helper * Move modules * Remove unused library * updated solCover to skip experimental contracts * Add test for removeSchedule * reverting solCover skip on experimental folder
* Fixed linter erros: no-constant, quotes, visibility-first, operator-whitespace, indentation * Fixed linter erros: exclude IMedianizer and OraclizeI, turn off "security/no-block-members" * Fixed linter erros: max-len * Fixed linter erros: minor fix after merge * Fixed linter erros: added comments "solium-disable-next-line" for security/no-inline-assembly, security/no-call-value, security/no-low-level-calls, security/no-send, no-empty-blocks * Fixed linter erros: max-len * Fixed linter erros: added /*solium-disable-next-line security/no-block-members*/ * Fixed linter erros: fix missed errors * Fixed linter erros: error-reason * Fixed linter erros: reverted adding error reasons since it introduces "out of gas" errors for ERC20DividendCheckpoint, EtherDividendCheckpoint, ModuleFactory, SecurityToken * Fixed linter erros: applied review comments * minor styling problem fixing * minor fixes
Final Touches
* change the description * fix grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.