Completed calibration tab #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto ROI can now run without an roi being set initially. Also fixed a bug with the osc receiver that prevented it from initializing.
Contains Min and Max values for manually calibrating model output. Also moved the calibration mode setting from the camera tab to avoid confusion.
Added check so we don't attempt to convert a non-float str to a float.
|
This might break serial port listing and selecting because of the index from the new camera name functions in main. |
Armada3334
reviewed
Sep 23, 2024
There was a problem hiding this comment.
line 90 removed the and condition for capture_source not in camera_list
Seeing as this detects if the source is over COM, I assume this is fine, but wanted to comment here just in case that secondary check is still necessary.
Armada3334
reviewed
Sep 23, 2024
Armada3334
reviewed
Sep 23, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the calibration tab and now it no longer crashes when attempting to convert the input string to a float when a non float string is present. As for the autoroi button, I might just end up removing it in another pr as we are not going to have a model for it.