fix: SocketConnectOptions typo #486
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Fixed a typo in the type name from
SocketConnectOption
→SocketConnectOptions
to match thephoenix
package.Impact of Change
Bug fix
Feature
Performance Improvement
Refactoring
Other: Describe here
Detailed Technical Description of Change
The code was referencing
SocketConnectOption
without the trailing "s", which does not exist in thephoenix
package. Updated all references to the correctSocketConnectOptions
type to ensure proper typings and prevent TypeScript errors.Testing Approach and Results
Checked the codebase to ensure all type references now match the package. Verified that TypeScript no longer reports errors related to this type. No runtime behavior changes.
Collateral Work or Changes
No other systems or configs are affected. This is purely a type fix.
Operational Impact
No operational changes. No new metrics, dashboards, or alerts required.