Replace format_template() function by Binder.format_toml_template() method
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should enable code simplifications in the future. For now, there is one functional change: it is no longer allowed to pass a dataclass which contains types or constructs that are not supported by `Binder`. I don't think this will prevent any likely real-world workflows.
This is preparation for adding more class info.
To fetch these we need to parse the source file, so that's an amount of work that we'd rather do just once.
The `_format_value_for_field()` function had a lot of overlap with `_get_fields()` and re-using `field_types` for formatting not only removes the duplicate code but also saves work.
We have `parse_toml()`, so it's consistent to also be explicit in output methods. And if we ever add JSON support, it's necessary to be explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17