Add whitespace checks for match and case - 2nd attempt
#1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+510
to
+494
| match = MATCH_CASE_REGEX.match(logical_line) | ||
| if match: | ||
| if match[1] == ' ': | ||
| return | ||
| if match[1] == '': | ||
| yield match.start(1), "E275 missing whitespace after keyword" | ||
| elif '\t' in match[1]: | ||
| yield match.start(1), "E273 tab after keyword" | ||
| else: | ||
| yield match.start(1), "E271 multiple spaces after keyword" |
Member
Author
|
Closing this as there doesn't seem to be interest to implement it. Please feel free to reuse the code as you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt after #990
I've improved the default
MATCH_CASE_REGEX, especially the lookahead part.It now requires at least one non-whitespace char to be present between
caseand:. Furthermore it matches end of line or begin of comment.To account for case statements written inline, I've added fallback logic. That uses the tokenizer to check the
:isn't inside any brackets.