use pyo3::intern!

[jessekrubin]

Added pyo3::intern!() where applicable.

I imagine this would be beneficial in that some of these call_method/getattr/etc places get called often.

Food for thought: would it be a good idea to dedupe interns pyo3::intern!(py, "run_until_complete") appears twice? would dedupling help?

PS: obviously these are unpaid interns

[davidhewitt]

Food for thought: would it be a good idea to dedupe interns pyo3::intern!(py, "run_until_complete") appears twice? would dedupling help?

Deduping is potentially useful if it's easy to do; it will reduce the amount of static storage used (by the interior of the macro). I think that the same Python string would be shared between duplicate uses of intern!, though.

[jessekrubin]

@davidhewitt I (also) think it would work? but I certainly dont know better than you!

Would inlining possibly cause problems?

I have been sharing (unpaid) interns (here and also-here) and it seems to work good?

EDIT: to clarify, I have been meaning to ask you or make a pyo3 discussion to figure out of intern-deduping actually does anything.

---

raw links

• https://github.com/jessekrubin/ry/blob/main/crates/ryo3-jiff/src/interns.rs
• https://github.com/jessekrubin/ry/blob/3c29217e94271fa4c75dec80491ad5e796ea84fa/crates/ryo3-pydantic/src/lib.rs#L20

[jessekrubin]

@davidhewitt updated the branch... let me know if I should dedupe

[jessekrubin]

@davidhewitt any thoughts on this? is it good to go?

[davidhewitt]

LGTM, thanks! Sorry for the delay.

[jessekrubin]

No prob.