deprecate pyfn attribute
#5384
Merged
deprecate pyfn attribute
#5384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
reviewed
Aug 31, 2025
Contributor
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
Sounds good to me! Do we need a UI test to make sure the deprecation is correctly emitted?
Member
Author
|
Good idea, will add one, probably tomorrow 👍 |
Icxolu
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #694
Now that we have had declarative modules for some time, and they have been shown to work well, I think we are ready to deprecate the
#[pyfn]attribute which is an old variant ofpyfunctionwhich worked inside imperative#[pymodule]functions.