Skip to content

Add method to remove a word from trie #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2020
Merged

Add method to remove a word from trie #483

merged 5 commits into from
Oct 9, 2020

Conversation

korakot
Copy link
Member

@korakot korakot commented Oct 9, 2020

Add a method to remove 1 word from the trie.

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2020 •
edited
Loading

Hello @korakot! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-09 09:52:18 UTC

@korakot korakot changed the title Update trie.py Add method to remove a word from trie Oct 9, 2020
@coveralls
Copy link

coveralls commented Oct 9, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 95.492% when pulling aaced0b on korakot-patch-1 into c932d3f on dev.

@bact bact self-requested a review October 9, 2020 09:27
bact
bact approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added a test case.

(the variable name is really "threes"?)

@bact bact added this to the 2.3 milestone Oct 9, 2020
@bact bact added the enhancement enhance functionalities label Oct 9, 2020
@korakot
Copy link
Member Author

korakot commented Oct 9, 2020

threes is probably a bad variable name. I'll change it to just 'data' then.

@bact bact merged commit 329812e into dev Oct 9, 2020
@bact bact deleted the korakot-patch-1 branch October 12, 2020 14:07
@bact bact added the hacktoberfest-accepted hacktoberfest accepted pull requests. label Oct 17, 2020
@bact bact mentioned this pull request Dec 9, 2020
Closed
@wannaphong wannaphong mentioned this pull request Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact bact approved these changes

@wannaphong wannaphong wannaphong approved these changes

Assignees

No one assigned

Labels

enhancement enhance functionalities hacktoberfest-accepted hacktoberfest accepted pull requests.

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

5 participants

@korakot @pep8speaks @coveralls @bact @wannaphong