Skip to content

thai_strftime: Normalize output for unsupported directive #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2020
Merged

thai_strftime: Normalize output for unsupported directive #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16add7f
Normalize strftime output in case of unsupported directive. Makes out…
bact Dec 6, 2020
93fcc2b
Merge pull request #1 from bact/dev
bact Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pythainlp/util/strftime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,10 @@ def _std_strftime(dt_obj: datetime, fmt_char: str) -> str:
str_ = ""
try:
str_ = dt_obj.strftime(f"%{fmt_char}")
if str_ == f"%{fmt_char}":
if not str_ or str_ == "%{}".format(fmt_char):
# normalize outputs for unsupported directives
# in different platforms
# unsupported "%Q" in platform A may return "Q"
# unsupported "%Q" in platform A may return "%Q"
# "%Q" may result "%Q", "Q", or "", make it "Q"
str_ = fmt_char
except ValueError as err:
# Unsupported directives may raise ValueError on Windows,
Expand Down