Deprecated syllable_tokenize #322 #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syllable_tokenize is deprecated, use subword_tokenize instead
|
Todo
|
|
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-04-22 17:32:08 UTC |
bact
requested changes
Apr 19, 2021
Comment on lines
303
to
307
| * *tcc* (default) - Thai Character Cluster (Theeramunkong et al. 2000) | ||
| * *etcc* - Enhanced Thai Character Cluster (Inrut et al. 2001) | ||
| * *wangchanberta* - SentencePiece from wangchanberta model. | ||
| * *dict* (default) - newmm word tokenizer with a syllable dictionary | ||
| * *ssg* - CRF syllable segmenter for Thai |
There was a problem hiding this comment.
"dict" is not a default subword tokenization engine.
Current default is "tcc",
according to DEFAULT_SUBWORD_TOKENIZE_ENGINE constant in
https://github.com/PyThaiNLP/pythainlp/blob/dev/pythainlp/tokenize/__init__.py
"dict (default) - newmm..." should be just "* dict - newmm..."
bact
approved these changes
Apr 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syllable_tokenize is deprecated, use subword_tokenize instead #322
What does this changes
Deprecated syllable_tokenize
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.