Skip to content

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jun 1, 2021

What does this changes

Add get_corpus_default_db and thainer 1.5 model

What was wrong

Now, You can add corpus on default_db,json and you dont load last thainer model from Internet.

How this fixes it

Description of how the changes fix the issue.

Fixes #575 #298

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jun 1, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-01 17:30:28 UTC

@coveralls
Copy link

coveralls commented Jun 1, 2021

Coverage Status

Coverage decreased (-0.01%) to 95.961% when pulling 0895ab7 on add-thainer-model into ab888cc on dev.

@bact bact added the corpus corpus/dataset-related issues label Jun 1, 2021
@bact bact added this to the 2.4 milestone Jun 1, 2021
@bact
Copy link
Member

bact commented Jun 1, 2021

May need test for get_corpus_default_db()

  • what if name or version is None or not found?

@wannaphong
Copy link
Member Author

May need test for get_corpus_default_db()

* what if `name` or `version` is None or not found?

The load model function maybe failed. I used it in get_corpus_path function.

@wannaphong wannaphong merged commit 0c340d3 into dev Jun 5, 2021
@wannaphong wannaphong deleted the add-thainer-model branch August 10, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
corpus corpus/dataset-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThaiNER - URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED]
4 participants