Skip to content

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jun 15, 2021

What does this changes

I add pythainlp.word_vector.WordVector. It's class for word vector. Its support thai2fit, ltw2v and more (in future).

Fixes #582

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@wannaphong wannaphong requested a review from bact June 15, 2021 14:46
@pep8speaks
Copy link

pep8speaks commented Jun 15, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-15 15:18:43 UTC

@coveralls
Copy link

coveralls commented Jun 15, 2021

Coverage Status

Coverage increased (+0.01%) to 95.998% when pulling dc96f02 on add-ltw2v-word_vector into b244359 on dev.

@bact bact added the enhancement enhance functionalities label Jun 16, 2021
@wannaphong wannaphong merged commit 730d747 into dev Jul 11, 2021
@wannaphong wannaphong added this to the 2.4 milestone Jul 18, 2021
@wannaphong wannaphong deleted the add-ltw2v-word_vector branch July 29, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LTW2V to pythainlp.word_vector
4 participants