Fix token_max_len bug that makes it always zero #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Fix safe mode algorithm that choose the cut-off position.
What was wrong
token_max_len = 0
was inside for loop, makes it always reset to zero.This make the cut-off position may not be the one that covers longest token.
How this fixes it
Move
token_max_len = 0
outside of for loop.Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.