Skip to content

Conversation

wannaphong
Copy link
Member

What does this changes

Add Chinese-Thai Machine Translation

from Ai builder

Google colab for testing: https://colab.research.google.com/drive/1XzMjQ170bsfkujFds0Fkgyi6vPxR8x-r?usp=sharing

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@coveralls
Copy link

coveralls commented Jul 6, 2021

Coverage Status

Coverage increased (+0.05%) to 95.976% when pulling 606c306 on Add-th-zh-translate into 9596e11 on dev.

@cstorm125
Copy link
Member

Would be good to warn users that the models only work with torch==1.8.0 and transformers==4.6.0

@cstorm125
Copy link
Member

cstorm125 commented Jul 7, 2021

Actually on second thought, @wannaphong should we refactor translator class to let users choose source and target languages? If we want to do more language pairs then it will eventually be too many classes with current setup.

@pep8speaks
Copy link

pep8speaks commented Jul 10, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-13 15:06:34 UTC

@wannaphong wannaphong requested a review from bact July 13, 2021 16:50
@wannaphong wannaphong merged commit ad20a1e into dev Jul 15, 2021
@wannaphong wannaphong added this to the 2.4 milestone Jul 18, 2021
@wannaphong wannaphong deleted the Add-th-zh-translate branch July 29, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants