-
Notifications
You must be signed in to change notification settings - Fork 285
Add misspell module #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add misspell module #614
Conversation
Hello @heytitle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-07 05:51:28 UTC |
Do you wants hacktoberfest to this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may need to add docs to pythainlp/mispell-generator/docs/api/tools.rst
.
.. autofunction:: misspell
All test of this PR are passed but some test are broke. I will fix it in dev branch. |
Thanks for the suggestion @wannaphong!
I would let you and @bact decide whether the contribution of this PR is sufficient for the tag. |
I approve and I think this PR is sufficient for the tag of hacktoberfest. and you? @bact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Perhaps, if this PR is ready, we can conclude and merge it. For the command line, we can implement it in a separate PR; its issue has been created (#615). |
What does this changes
This PR implements #549
Note for self:
pytest ./tests/test_misspell.py
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.