Skip to content

Conversation

p16i
Copy link
Contributor

@p16i p16i commented Oct 1, 2021

What does this changes

This PR implements #549

Note for self:

  • To run the test: pytest ./tests/test_misspell.py
  • implement an command line to produce a misspelled version of a file (line by line)
  • using the command line to generate multiple files with different datasets and see how word segmentations performance are.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Oct 1, 2021

Hello @heytitle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-07 05:51:28 UTC

@p16i p16i requested review from bact and wannaphong October 1, 2021 20:48
@bact bact added corpus corpus/dataset-related issues enhancement enhance functionalities labels Oct 2, 2021
@wannaphong
Copy link
Member

Do you wants hacktoberfest to this pull request?

Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may need to add docs to pythainlp/mispell-generator/docs/api/tools.rst.

.. autofunction:: misspell

@wannaphong
Copy link
Member

All test of this PR are passed but some test are broke. I will fix it in dev branch.

@p16i
Copy link
Contributor Author

p16i commented Oct 2, 2021

Thanks for the suggestion @wannaphong!

Do you wants hacktoberfest to this pull request?

I would let you and @bact decide whether the contribution of this PR is sufficient for the tag.

@wannaphong
Copy link
Member

Thanks for the suggestion @wannaphong!

Do you wants hacktoberfest to this pull request?

I would let you and @bact decide whether the contribution of this PR is sufficient for the tag.

I approve and I think this PR is sufficient for the tag of hacktoberfest. and you? @bact

@bact bact added Hacktoberfest for Hacktoberfest event hacktoberfest-accepted hacktoberfest accepted pull requests. labels Oct 7, 2021
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p16i
Copy link
Contributor Author

p16i commented Oct 7, 2021

Perhaps, if this PR is ready, we can conclude and merge it. For the command line, we can implement it in a separate PR; its issue has been created (#615).

@wannaphong wannaphong added this to the 3.0 milestone Oct 9, 2021
@wannaphong wannaphong linked an issue Oct 9, 2021 that may be closed by this pull request
@wannaphong wannaphong merged commit 2ae3f7a into dev Oct 9, 2021
@bact bact deleted the mispell-generator branch November 8, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
corpus corpus/dataset-related issues enhancement enhance functionalities Hacktoberfest for Hacktoberfest event hacktoberfest-accepted hacktoberfest accepted pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misspelling Model
4 participants