Skip to content

Conversation

chameleonTK
Copy link
Contributor

What does this change do?

Add a normalising rule for Lakkhangyao
According to this, it should only follow, and . Apart from that it should be normalised to .

How this fixes it

Add the following regex in reorder_vowels function

("([^\u0e24\u0e26])\u0e45", "\\1\u0e32"),  # Lakkhangyao -> Sara Aa

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • [/] Passed code styles and structures
  • [/] Passed code linting checks and unit test

@coveralls
Copy link

coveralls commented May 17, 2022

Coverage Status

Coverage remained the same at 97.147% when pulling 4e22fda on chameleonTK:feat/add-norm-rules into 14e9a4d on PyThaiNLP:dev.

@wannaphong wannaphong added this to the 3.1 milestone May 18, 2022
@wannaphong
Copy link
Member

Thank you for contributing!

@wannaphong wannaphong merged commit 3d2cd79 into PyThaiNLP:dev May 18, 2022
wannaphong added a commit that referenced this pull request Sep 1, 2022
See [3.1 Milestone](https://github.com/PyThaiNLP/pythainlp/milestone/16).

## What is new?
### Deprecation and other API changes
#687 Remove deprecated function
- pythainlp.word_vector; doesnt_match, get_model, most_similar_cosmul, sentence_vectorizer, similarity. use WordVector class instead
- pythainlp.util.delete_tone. use pythainlp.util.remove_tonemark instead
- Remove pythainlp.util.time_time. use pythainlp.util.time_to_thaiword instead
- pythainlp.tokenize.syllable_tokenize. use pythainlp.tokenize.subword_tokenize instead

### Name Entity Tagging
- #665 Add Thai-NNER `pythainlp.tag.NNER`
- #658 Add LST20NER onnx model. It is LST20NER model to onnx model from fine-turning by [WangchanBERTa model](https://huggingface.co/airesearch/wangchanberta-base-att-spm-uncased).

### Transliteration
- #659 Add ISO 11940 transliteration
- #660 Add Thai W2P v0.2
- #686 Add wunsen
- #694 Wunsen Mandarin and Japanese update

### PyThaiNLP Corpus downloader
- #656 Add support zip/tar.gz to download corpus

### Text normalization
- #673 Add a normalising rule for Lakkhangyao ๅ

### Translate
- #674 add gpu option

### Text summarize
- #679 Add mt5 cpe kmutt thai sentence sum

### Util
- #682 Add live-dead syllable classification
- #684 Add live dead syllable classify
- #690 Add tone detector

### Other
- #689 map NG tag to PART
- #691 Remove TinyDB as a dependency
- #692 Fix notifications that newer versions of corpora are available
@wannaphong wannaphong mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants