Skip to content

Delete all LST20 model #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2022
Merged

Delete all LST20 model #728

merged 6 commits into from
Oct 18, 2022

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Oct 12, 2022 •
edited by bact
Loading

To resolve #727, I think we should remove all model that trained from LST20 Corpus.

See discussion in #725

@wannaphong wannaphong added this to the 3.2 milestone Oct 12, 2022
@wannaphong wannaphong changed the title Delete all LST20 model [WIP] Delete all LST20 model Oct 12, 2022
@wannaphong
Copy link
Member Author

This pull request will remove

  • lst20 / lst20_ud in pythainlp.tag.pos_tag
  • pythainlp.tokenize.clause_tokenize
  • lst20 in pythainlp.augment.wordnet
  • lst20_onnx in pythainlp.tag.NER

This was referenced Oct 12, 2022
Closed
Closed
Closed
@coveralls
Copy link

coveralls commented Oct 12, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 94.354% when pulling 7896113 on delete-lst20-model into 2606f85 on dev.

@bact bact added the corpus corpus/dataset-related issues label Oct 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wannaphong wannaphong mentioned this pull request Oct 13, 2022
Merged
@wannaphong wannaphong changed the title [WIP] Delete all LST20 model Delete all LST20 model Oct 13, 2022
@wannaphong wannaphong mentioned this pull request Oct 13, 2022
Merged
@wannaphong
Copy link
Member Author

The CI error is come from fast.ai.

@wannaphong wannaphong requested a review from bact October 13, 2022 19:42
bact
bact approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wannaphong wannaphong merged commit 3a65056 into dev Oct 18, 2022
@wannaphong wannaphong mentioned this pull request Oct 28, 2022
Closed
@wannaphong wannaphong mentioned this pull request Dec 7, 2022
Closed
@wannaphong wannaphong mentioned this pull request Apr 1, 2023
Merged
@wannaphong wannaphong mentioned this pull request Apr 14, 2023
Merged
@wannaphong wannaphong deleted the delete-lst20-model branch December 4, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact bact approved these changes

Assignees

No one assigned

Labels

corpus corpus/dataset-related issues

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

Remove the model that may be legal problems

3 participants

@wannaphong @coveralls @bact