Skip to content

Conversation

new5558
Copy link
Contributor

@new5558 new5558 commented Oct 25, 2022

What does this changes

Since pep8speaks has stopped working (temporary?), we may need an alternative way of checking code format for a meanwhile.

What was wrong

Resolve #744

How this fixes it

  • Format all code according to CONTRIBUTION.md
  • Setup black formatted as Github action workflow This code will throw error (stop Github workflow) as default if incorrect format detected

Fixes #...

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

How I tested this PR

I used Act to test Github actions locally

  1. Prerequisite: docker
  2. Install Act curl https://raw.githubusercontent.com/nektos/act/master/install.sh | sudo bash
  3. Run ./bin/act -W .github/workflows/lint.yml
  4. Check if the workflow runs successfully

@new5558
Copy link
Contributor Author

new5558 commented Oct 25, 2022

Should --line-length still be 79? Or should I set it to 127 to match with flake8 config?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@coveralls
Copy link

coveralls commented Oct 25, 2022

Coverage Status

Coverage decreased (-1.8%) to 92.481% when pulling e07673f on new5558:style/format into 97b1a51 on PyThaiNLP:dev.

@wannaphong
Copy link
Member

Should --line-length still be 79? Or should I set it to 127 to match with flake8 config?

I found line length 79 that It is not enough for write text processing function but I don't sure that what the line length should be, so It should still be 79 until found the line length that enough for write text processing function.

Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@wannaphong wannaphong added refactoring a technical improvement which does not add any new features or change existing features. hacktoberfest-accepted hacktoberfest accepted pull requests. labels Oct 25, 2022
@wannaphong wannaphong merged commit 9adc738 into PyThaiNLP:dev Oct 26, 2022
@wannaphong wannaphong added this to the 4.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted hacktoberfest accepted pull requests. refactoring a technical improvement which does not add any new features or change existing features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repo's code have Inconsistent code format with the contribution guide

3 participants