Skip to content

Doc: Lst20 deprecation warning for 3.1.1 (#749) #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2022
Merged

Doc: Lst20 deprecation warning for 3.1.1 (#749) #752

merged 4 commits into from
Oct 30, 2022

Conversation

noppayut
Copy link
Contributor

What does this changes

  • Add a deprecation message generator
  • Add deprecation messages to modules that use LST20 dataset

What was wrong

LST20 is going to be removed in version 4.0.0. Currently no warning message.

How this fixes it

Add a deprecation warning message to inform user.

Fixes #749

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • [✓] Passed code styles and structures
  • [✓] Passed code linting checks and unit test no unit test for this PR, let me know if you need one.

@wannaphong
Copy link
Member

Can you add a commit to run unit test? I fixed the unit test.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wannaphong wannaphong added this to the 3.1 milestone Oct 30, 2022
wannaphong
wannaphong approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test passed. Thank you for this pull request! 💯

@wannaphong wannaphong merged commit ddd785d into PyThaiNLP:3.1 Oct 30, 2022
wannaphong added a commit that referenced this pull request Oct 30, 2022
@wannaphong
PyThaiNLP 3.1.1
04f783a 
PyThaiNLP v3.1.1 is the releases updates of PyThaiNLP v3.1.0.

-  Add Reduce import time #719 to PyThaiNLP 3.1.1 #753
-  Doc: Lst20 deprecation warning for 3.1.1 (#749) #752
@wannaphong wannaphong mentioned this pull request Oct 30, 2022
Merged
@noppayut
Copy link
Contributor Author

Sorry could you add hacktoberfest tag?

@wannaphong wannaphong added the hacktoberfest-accepted hacktoberfest accepted pull requests. label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted hacktoberfest accepted pull requests.
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@noppayut @wannaphong