Skip to content

Fix incorrect passing of flags to re.split #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix incorrect passing of flags to re.split #832

merged 1 commit into from
Aug 9, 2023

Conversation

hauntsaninja
Copy link
Contributor

This is a common mistake, see python/cpython#99918 (comment)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 83.901% (+2.1%) from 81.842% when pulling b4d4f37 on hauntsaninja:hauntsaninja-patch-1 into 7569644 on PyThaiNLP:dev.

wannaphong
wannaphong approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wannaphong wannaphong merged commit 61700f1 into PyThaiNLP:dev Aug 9, 2023
@wannaphong wannaphong mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauntsaninja @coveralls @wannaphong