Make expect for async closures take in Sendable closures #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younata
force-pushed
the
asyncexpression_sendable
branch
from
7732160 to
50139bd
Compare
younata
added a commit
that referenced
this pull request
Mar 17, 2024
younata
added a commit
that referenced
this pull request
Apr 11, 2024
younata
added a commit
that referenced
this pull request
Jun 18, 2024
younata
added a commit
that referenced
this pull request
Oct 14, 2024
younata
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of warnings in Nimble around using the async forms of
expect/expecta.This should have been included in #1067, but I forgot to push the commit. 🤦♀️