Make AsyncPredicate Sendable, constrain it to Sendable types #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
younata
added a commit
that referenced
this pull request
Mar 17, 2024
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
younata
added a commit
that referenced
this pull request
Apr 11, 2024
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
younata
added a commit
that referenced
this pull request
Jun 18, 2024
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
younata
added a commit
that referenced
this pull request
Oct 14, 2024
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
younata
added a commit
that referenced
this pull request
Dec 20, 2024
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of concurrency checking,
AsyncPredicateneeds to be Sendable. Part of that is that the closure needs to be Sendable andAsyncPredicateneeds to be constrained to only Sendable types.As part of interop with
AsyncPredicate,Predicateneeds to be Sendable. Though, it's ok to only makePredicateSendable when the type it works with isSendable(that is, we have:extension Predicate: Sendable where T: Sendable {}).This also fixes compiler errors in Nimble associated with making the closures passed to Predicate Sendable.