Skip to content

Conversation

@Sthing
Copy link
Collaborator

@Sthing Sthing commented May 3, 2017

No description provided.

@lsolesen
Copy link
Contributor

Thanks for the pull request. Do you mind writing a test case scenario for the change, so we avoid problems in future releases?

@lsolesen
Copy link
Contributor

@Sthing What about introducing a new class for the Invoicing API so the resulting end code will be more clear?

$client = new QuickPay_Invoice();

And that class utilize the client with the url?

@lsolesen
Copy link
Contributor

@Sthing What is your take on my suggestion for introducing another class for starting up the Invoice API?

@Sthing
Copy link
Collaborator Author

Sthing commented Sep 14, 2017

@lsolesen Ehm - I think it is ok, but I don't have the time to do it right now.

@welrachid
Copy link

Not sure this is still relevant.
https://github.com/QuickPay/quickpay-php-client/pull/84/commits

i made this solution, so i dont have to deal with multiple classes, since the only difference is the api endpoint. The rest is the same and therefore no need for another class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants