fix: reactivity after spreading props #7809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a0ee9b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-fix-spread-props-reactivity
branch
2 times, most recently
from
6846f0c to
6cc7bd0
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Aug 12, 2025
packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_jsx.snap
Outdated
Show resolved
Hide resolved
Varixo
force-pushed
the
v2-fix-spread-props-reactivity
branch
from
6cc7bd0 to
feae538
Compare
commit: |
Varixo
force-pushed
the
v2-fix-spread-props-reactivity
branch
from
feae538 to
65f073d
Compare
wmertens
requested changes
Aug 13, 2025
…in JSX components
Varixo
force-pushed
the
v2-fix-spread-props-reactivity
branch
from
65f073d to
1a0ee9b
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
gioboa
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spread props caused calling get trap for every props property. It means propsproxy will unwrap signals and pass flat value instead. Now we are using new _getVarProps, _getConstProps functions to direct get props object instead of using proxy