Skip to content

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 17, 2025

What is it?

  • Bug

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

…aths were relativized twice, adding a ../../
@maiieul maiieul requested a review from a team as a code owner August 17, 2025 17:01
Copy link

changeset-bot bot commented Aug 17, 2025

🦋 Changeset detected

Latest commit: 42397f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul
Copy link
Contributor Author

maiieul commented Aug 17, 2025

best way to test this would be to have an e2e test that verifies the prefetch bundles are properly generated in the manifest, but I don't know if we have something like that in place.

Copy link

pkg-pr-new bot commented Aug 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7835
npm i https://pkg.pr.new/@builder.io/qwik-city@7835
npm i https://pkg.pr.new/eslint-plugin-qwik@7835
npm i https://pkg.pr.new/create-qwik@7835

commit: 42397f4

Copy link
Contributor

github-actions bot commented Aug 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 42397f4

@maiieul maiieul self-assigned this Aug 17, 2025
@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Aug 17, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using it on a monorepo?

@maiieul
Copy link
Contributor Author

maiieul commented Aug 17, 2025

Yes that happened on qwik UI

gioboa
gioboa previously approved these changes Aug 17, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎢

@wmertens wmertens merged commit bc835b0 into QwikDev:main Aug 18, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 18, 2025
@github-actions github-actions bot mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants