-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: getRouteImports not adding prefetch route bundles because some paths were relativized twice, adding a ../../ #7835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aths were relativized twice, adding a ../../
🦋 Changeset detectedLatest commit: 42397f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
best way to test this would be to have an e2e test that verifies the prefetch bundles are properly generated in the manifest, but I don't know if we have something like that in place. |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using it on a monorepo?
Yes that happened on qwik UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎢
What is it?
Description
Checklist
pnpm change