Skip to content

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 17, 2025

What is it?

  • Bug

Description

route prefetch bundles with small probabilities aren't preloaded. This fixes this issue.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner August 17, 2025 17:21
Copy link

changeset-bot bot commented Aug 17, 2025

🦋 Changeset detected

Latest commit: a74c0e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a74c0e5

@maiieul maiieul self-assigned this Aug 17, 2025
@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Aug 17, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are ignoring the $invPreloadProbability$, right?

@maiieul
Copy link
Contributor Author

maiieul commented Aug 17, 2025

Hmmm yeah maybe we can remove it altogether @wmertens ?

@maiieul maiieul force-pushed the fix-preloader-not-preloading-prefetch-bundles-deps branch from d8b02bd to 8266847 Compare August 17, 2025 18:37
@maiieul maiieul force-pushed the fix-preloader-not-preloading-prefetch-bundles-deps branch from 930503e to a4f2ab0 Compare August 17, 2025 18:43
@maiieul maiieul changed the title fix: preloader not preloading prefetch bundles deps fix: preloader not preloading prefetch bundles deps because probability is too small Aug 17, 2025
@maiieul maiieul requested a review from wmertens August 17, 2025 18:52
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the @wmertens 's feedback

Copy link

pkg-pr-new bot commented Aug 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7836
npm i https://pkg.pr.new/@builder.io/qwik-city@7836
npm i https://pkg.pr.new/eslint-plugin-qwik@7836
npm i https://pkg.pr.new/create-qwik@7836

commit: a74c0e5

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge August 18, 2025 12:02
@wmertens wmertens merged commit bda6339 into QwikDev:main Aug 18, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 18, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👍

@github-actions github-actions bot mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants