Skip to content

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Aug 19, 2025

Remove the unsupported domino fork and reduces the core package size.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner August 19, 2025 21:19
Copy link

changeset-bot bot commented Aug 19, 2025

🦋 Changeset detected

Latest commit: 826324d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gioboa gioboa marked this pull request as draft August 19, 2025 21:24
@gioboa gioboa changed the title chore(testing): remove qwik/dom, use jsdom 💻 chore(testing): patch domino and remove qwik/dom 💻 Aug 20, 2025
@gioboa gioboa force-pushed the chore/remove-qwik-dom branch from c7a1ed3 to eb36ce8 Compare August 20, 2025 08:37
@gioboa gioboa marked this pull request as ready for review August 20, 2025 08:53
Copy link

pkg-pr-new bot commented Aug 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7842
npm i https://pkg.pr.new/@builder.io/qwik-city@7842
npm i https://pkg.pr.new/eslint-plugin-qwik@7842
npm i https://pkg.pr.new/create-qwik@7842

commit: eb36ce8

Copy link
Contributor

github-actions bot commented Aug 20, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview eb36ce8

Copy link
Member Author

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this PR small, I will remove the qwik dom files in another PR.

@gioboa gioboa changed the title chore(testing): patch domino and remove qwik/dom 💻 chore(testing): patch domino to remove qwik/dom 💻 Aug 20, 2025
@gioboa gioboa changed the title chore(testing): patch domino to remove qwik/dom 💻 chore(testing): patch domino to remove qwik-dom 💻 Aug 20, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥌

We should check how devs can do tests in their own projects, in the meantime this is a welcome cleanup

@wmertens wmertens merged commit a83f9ed into QwikDev:main Aug 20, 2025
14 checks passed
Copy link
Member Author

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmertens you are right, we need to release a qwik.dev npm package for it

@gioboa gioboa deleted the chore/remove-qwik-dom branch August 20, 2025 19:10
@github-actions github-actions bot mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants