Skip to content

fix: avoid conflicting restprops and props names #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2025
Merged

fix: avoid conflicting restprops and props names #7880

merged 2 commits into from
Aug 28, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Aug 28, 2025

  • any destructured props will be converted to _restProps to avoid iterating over props
  • fix conflicting _restProps name with component props

@Varixo Varixo self-assigned this Aug 28, 2025
@Varixo Varixo requested a review from a team as a code owner August 28, 2025 16:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 569b4a6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Aug 28, 2025
@Varixo Varixo force-pushed the v2-rest-props-conflicting-name branch 2 times, most recently from 4c4cc02 to 077267f Compare August 28, 2025 16:47
@Varixo Varixo force-pushed the v2-rest-props-conflicting-name branch from 077267f to a4fdf94 Compare August 28, 2025 16:48
@Varixo Varixo linked an issue Aug 28, 2025 that may be closed by this pull request
[🐞] optimizer gets confused about props #7665
Closed
@Varixo Varixo force-pushed the v2-rest-props-conflicting-name branch from a4fdf94 to 569b4a6 Compare August 28, 2025 16:51
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 28, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7880

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7880

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7880

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7880

commit: 569b4a6

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 569b4a6

wmertens
wmertens approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 870a90a into build/v2 Aug 28, 2025
23 checks passed
@wmertens wmertens deleted the v2-rest-props-conflicting-name branch August 28, 2025 17:29
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 28, 2025
@Varixo Varixo mentioned this pull request Aug 28, 2025
Closed
@github-actions github-actions bot mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] optimizer gets confused about props
3 participants
@Varixo @wmertens @gioboa