Skip to content

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Aug 30, 2025

Find the correct parent dom element from projected content

@Varixo Varixo self-assigned this Aug 30, 2025
@Varixo Varixo requested a review from a team as a code owner August 30, 2025 13:40
Copy link

changeset-bot bot commented Aug 30, 2025

🦋 Changeset detected

Latest commit: 16f5f84

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Aug 30, 2025
@Varixo Varixo linked an issue Aug 30, 2025 that may be closed by this pull request
Copy link

pkg-pr-new bot commented Aug 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7886
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7886
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7886
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7886

commit: 16f5f84

Copy link
Contributor

github-actions bot commented Aug 30, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 16f5f84

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦺

@wmertens wmertens merged commit 831ad08 into build/v2 Aug 30, 2025
20 checks passed
@wmertens wmertens deleted the v2-finding-dom-parent branch August 30, 2025 18:12
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 30, 2025
vnode = vnode_getDomParentVNode(vnode) as VNode;
export const vnode_getDomParent = (
vnode: VNode,
includeProjection = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐞] v2: ownerDocument is null during deserialization
3 participants