Skip to content

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Sep 2, 2025

Close #6911

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner September 2, 2025 18:41
Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: dd80d00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7902
npm i https://pkg.pr.new/@builder.io/qwik-city@7902
npm i https://pkg.pr.new/eslint-plugin-qwik@7902
npm i https://pkg.pr.new/create-qwik@7902

commit: 7e8de5c

Copy link
Contributor

github-actions bot commented Sep 2, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 7e8de5c

@gioboa gioboa changed the title docs: return 404 with new URL exception 🤙 docs: return 404 with invalid URL ✌️ Sep 2, 2025
wmertens
wmertens previously approved these changes Sep 3, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge (squash) September 3, 2025 06:16
maiieul
maiieul previously approved these changes Sep 3, 2025
Copy link
Contributor

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gioboa
Copy link
Member Author

gioboa commented Sep 3, 2025

There we go 👏

image

@gioboa gioboa requested a review from wmertens September 3, 2025 09:39
@gioboa gioboa changed the title docs: return 404 with invalid URL ✌️ fix: return 404 with invalid URL ✌️ Sep 3, 2025
auto-merge was automatically disabled September 3, 2025 10:35

Head branch was modified

@gioboa gioboa requested a review from maiieul September 3, 2025 13:58
@maiieul
Copy link
Contributor

maiieul commented Sep 3, 2025

Thanks @gioboa

LGTM

@maiieul maiieul merged commit 1f50628 into QwikDev:main Sep 3, 2025
14 checks passed
@gioboa gioboa deleted the fix/6911 branch September 3, 2025 15:46
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] GET request to "//" causes internal server error
3 participants