Skip to content

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Sep 9, 2025

Correctly handle spread props on element nodes

@Varixo Varixo self-assigned this Sep 9, 2025
@Varixo Varixo requested a review from a team as a code owner September 9, 2025 08:59
Copy link

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: 47c9284

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7929
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7929
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7929
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7929

commit: 47c9284

Copy link
Contributor

github-actions bot commented Sep 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 47c9284

@Varixo Varixo marked this pull request as draft September 9, 2025 09:28
@Varixo Varixo moved this from Backlog to In progress in Qwik Development Sep 9, 2025
@Varixo Varixo linked an issue Sep 9, 2025 that may be closed by this pull request
@Varixo Varixo marked this pull request as ready for review September 9, 2025 12:35
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Sep 9, 2025
@Varixo Varixo moved this from Waiting For Review to In progress in Qwik Development Sep 9, 2025
@Varixo Varixo force-pushed the v2-spread-props-element-node branch 2 times, most recently from f958b1f to ff77362 Compare September 10, 2025 08:06
@Varixo Varixo force-pushed the v2-spread-props-element-node branch from ff77362 to 47c9284 Compare September 10, 2025 08:11
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Sep 10, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 85e0c73 into build/v2 Sep 10, 2025
23 checks passed
@wmertens wmertens deleted the v2-spread-props-element-node branch September 10, 2025 09:51
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Sep 10, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏Great 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[🐞] [v2] class merging doesn't work on string elements

3 participants