Skip to content

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Sep 21, 2025

vite in dev mode adds <script type="module" src="/@vite/client"></script> with new line at the end. This is confusing Qwik when resuming.
Also the second argument can be headers.

@Varixo Varixo self-assigned this Sep 21, 2025
@Varixo Varixo requested a review from a team as a code owner September 21, 2025 14:48
Copy link

changeset-bot bot commented Sep 21, 2025

🦋 Changeset detected

Latest commit: ce0541d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Sep 21, 2025
Copy link

pkg-pr-new bot commented Sep 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7981
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7981
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7981
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7981

commit: ce0541d

Copy link
Contributor

github-actions bot commented Sep 21, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview ce0541d

@Varixo Varixo marked this pull request as draft September 21, 2025 15:03
@Varixo Varixo marked this pull request as ready for review September 23, 2025 16:44
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit bdba2fb into build/v2 Sep 24, 2025
20 checks passed
@wmertens wmertens deleted the v2-trim-vite-script-tag branch September 24, 2025 15:15
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants