Speedup ntriples and nquads parsing. #1323
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same code change as in #1317 but on a brand new branch and #1300
The performance test is make with parsing:
The general idea is to use a single regular expression to parse the line into its three or four individual components.
nquads parsing reuse much more ntriples codes than before.
Windows:
14.71s => 12.20 : 17% faster
Linux: 13.12 => 12.45: 5% faster.
Please note that about 15% of time is spent in codecs.readline(), implying UTF-8 conversions due to opening the file in "rb" mode. handling only str instead of bytes would easily speed things up.