Skip to content

[smoke-limbo] Remove unnecessary map order requirements #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: aomp-dev
Choose a base branch
from
Open

[smoke-limbo] Remove unnecessary map order requirements #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
830762b
[smoke-limbo] Remove unnecessary map order requirements
ro-i Oct 27, 2025
8ca2c34
separate submit DAG from retrieve DAG
ro-i Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions test/smoke-limbo/usm-locals-xnack-disabled-xnack-any-apu-maps/usm_locals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ int main() {
for(size_t t = 0; t < 5; t++)
k[t] = -t;

/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
#pragma omp target update to(z[:10])

#pragma omp target map(tofrom:k[:5]) map(always, tofrom:x) map(tofrom:y)
Expand All @@ -30,10 +30,13 @@ int main() {
z[t]++;
printf("Device pointer for k = %p, k[3] = %d\n", k, k[3]);
}
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
// Note separate the two DAGs to ensure that retrieving is happening after
// submitting.
/// CHECK: launch_kernel:
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
#pragma omp target update from(z[:10])

// Note: when the output is redirected rather than printed at the console,
Expand Down
19 changes: 11 additions & 8 deletions test/smoke-limbo/usm-locals-xnack-disabled-xnack-any/usm_locals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ int main() {
for(size_t t = 0; t < 5; t++)
k[t] = -t;

/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
#pragma omp target update to(z[:10])

#pragma omp target map(tofrom:k[:5]) map(always, tofrom:x) map(tofrom:y)
Expand All @@ -30,10 +30,13 @@ int main() {
z[t]++;
printf("Device pointer for k = %p, k[3] = %d\n", k, k[3]);
}
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
// Note separate the two DAGs to ensure that retrieving is happening after
// submitting.
/// CHECK: launch_kernel:
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
#pragma omp target update from(z[:10])

// Note: when the output is redirected rather than printed at the console,
Expand Down
19 changes: 11 additions & 8 deletions test/smoke-limbo/usm-locals-xnack-disabled-xnack-minus/usm_locals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ int main() {
for(size_t t = 0; t < 5; t++)
k[t] = -t;

/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
#pragma omp target update to(z[:10])

#pragma omp target map(tofrom:k[:5]) map(always, tofrom:x) map(tofrom:y)
Expand All @@ -30,10 +30,13 @@ int main() {
z[t]++;
printf("Device pointer for k = %p, k[3] = %d\n", k, k[3]);
}
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
// Note separate the two DAGs to ensure that retrieving is happening after
// submitting.
/// CHECK: launch_kernel:
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
#pragma omp target update from(z[:10])

// Note: when the output is redirected rather than printed at the console,
Expand Down
17 changes: 10 additions & 7 deletions test/smoke-limbo/usm-locals-xnack-enabled-xnack-any-non-apu/usm_locals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ int main() {
for(size_t t = 0; t < 5; t++)
k[t] = -t;

/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
#pragma omp target update to(z[:10])

#pragma omp target map(to:k[:5]) map(always, tofrom:x) map(tofrom:y)
Expand All @@ -32,9 +32,12 @@ int main() {
printf("Device pointer for k = %p, k[3] = %d\n", k, k[3]);
}
#pragma omp target update from(z[:10])
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
// Note separate the two DAGs to ensure that retrieving is happening after
// submitting.
/// CHECK: launch_kernel:
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})

// Note: when the output is redirected rather than printed at the console,
// the printf'd strings are printed AFTER all the OpenMP runtime library
Expand Down
17 changes: 10 additions & 7 deletions test/smoke-limbo/usm-locals-xnack-enabled-xnack-plus-non-apu/usm_locals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ int main() {
for(size_t t = 0; t < 5; t++)
k[t] = -t;

/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_submit_async: {{.*}} 0 ({{.*}} 20, {{.*}})
#pragma omp target update to(z[:10])

#pragma omp target map(to:k[:5]) map(always, tofrom:x) map(tofrom:y)
Expand All @@ -31,9 +31,12 @@ int main() {
printf("Device pointer for k = %p, k[3] = %d\n", k, k[3]);
}
#pragma omp target update from(z[:10])
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
// Note separate the two DAGs to ensure that retrieving is happening after
// submitting.
/// CHECK: launch_kernel:
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 40, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})
/// CHECK-DAG: data_retrieve_async: {{.*}} 0 ({{.*}} 4, {{.*}})

// Note: when the output is redirected rather than printed at the console,
// the printf'd strings are printed AFTER all the OpenMP runtime library
Expand Down