Fixing the shape to use in padding calculation #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshtras
requested review from
Alexei-V-Ivanov-AMD,
divakar-amd,
maleksan85,
shajrawi and
sunway513
as code owners
shajrawi
previously approved these changes
Mar 7, 2025
divakar-amd
reviewed
Mar 7, 2025
divakar-amd
previously approved these changes
Mar 7, 2025
shajrawi
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for upstreaming MoE padding
Fixing accuracy regression induced by vllm-project#12185
In upstream B.shape[2] and A.shape[1] are supposed to match, but not when using moe padding