Skip to content

Do not re-validate output is utf8 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Do not re-validate output is utf8 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions datafusion/physical-plan/src/aggregates/group_values/group_column.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,11 +592,17 @@ impl<B: ByteViewType> ByteViewGroupValueBuilder<B> {

let views = ScalarBuffer::from(views);

Arc::new(GenericByteViewArray::<B>::new(
views,
completed,
null_buffer,
))
// Safety:
// * all views were correctly made
// * (if utf8): Input was valid Utf8 so buffer contents are
// valid utf8 as well
unsafe {
Arc::new(GenericByteViewArray::<B>::new_unchecked(
views,
completed,
null_buffer,
))
}
}

fn take_n_inner(&mut self, n: usize) -> ArrayRef {
Expand Down