Patch attiny85 PCMSK register #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahix
force-pushed
the
patch_attiny85_pcmsk
branch
from
78b331f to
d1f7f93
Compare
Rahix
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Hi,
I'm so sorry for loosing track of this :( Thanks a lot again for your work here! It's looking great already. The write-constraint thing is something I'm afraid we'll have to keep as it is for now. This will be fixed as soon as we upgrade to a newer svdtools I believe.
Comment on lines
+102
to
+105
| # This doesn't work: | ||
| # _modify: | ||
| # PCMSK: | ||
| # _write_constraint: [0, 63] |
There was a problem hiding this comment.
Yeah, the version of svdtools which we are using at the moment doesn't seem to support updating the write constraint of whole registers :/
Let's keep it the way you wrote it so we can uncomment the block once we upgrade to a version of svdtools that does support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #130 by adding fields for pins where the pin change interrupt can be enabled. I.e. it is possible to use this
instead of this:
Since the two most significant bits of PCMSK on the attiny85 are reserved, it would make sense to change the write constraint to
[0, 63], but I failed to achieve this. the code is commented in commit 78b331f . Because of this, the PR is still a draft.