Do not depend on "rails" gem, depend on parts of Rails that RailsRealFavicon uses

[adamniedzielski]

Description

RailsRealFavicon specifies a dependency on rails gem -

rails_real_favicon/rails_real_favicon.gemspec

Line 20 in 32fa257

s.add_dependency "rails", ">= 3.1"

rails is just an "umbrella gem" that depends on all the components of Ruby on Rails framework - https://github.com/rails/rails/blob/86ca5b254109e64edeb6e142e656b8a8c247cac8/rails.gemspec - ActiveSupport, ActionPack, ActiveRecord, ...

I want to avoid installing actioncable gem in my Rails application. When RailsRealFavicon specifies rails gem as a dependency then actioncable becomes my transitive dependency automatically and there is no way to avoid installing it.

Proposal

Depend only on these parts of Rails that RailsRealFavicon actually uses, for example:

gem.add_dependency "railities", ">= 3.1.0"
gem.add_dependency "actionview", ">= 3.1.0"

I'm happy to make a PR if you accept the change.

[phbernard]

That makes sense. I would be glad to merge your PR!

[phbernard]

No news of this issue. I admit I don't know how to handle it, apart from a trial-and-error process until I find the minimum set of dependencies (which I won't do :) ).

Don't hesitate to submit a PR if this is something you are willing to do.

[nimmolo]

@phbernard 👋 Are you still open to a PR?
I've done PRs for this for solid_queue and for mission_control_jobs. I believe i could handle it.

I'd need some pointers for how you set up tests for the gem.
I'm also curious about the json dependency, which is locked at version < 3 and mentioned in #40.

[phbernard]

Thank you @nimmolo for your kind proposal!

This package is actually no longer needed. The latest version of the favicon for Rails doesn't use any gem. So I'm not really willing to support this package any longer.