Prevent compilers from using FMA instructions #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FMAs where the different rounding can lead to a change in control flow.
langou
reviewed
Jul 12, 2024
langou
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031
Description
As described in #1031 when the compiler uses FMA instructions, errors in
?GEEVXcan increase up toSQRT(EPS). The different rounding of the FMA instructions causes a change in control flow, which produces the errors. This MR uses explicit parentheses to prevent the compiler from using FMA instructions for those results, which are compared against zero in subsequent if-statements.Checklist