Skip to content

Fix sorcsd #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2022
Merged

Fix sorcsd #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a44057
Revert "SORCSD: fix documentation on matrix dimensions"
weslleyspereira Aug 5, 2022
02836f3
Revert "SORCSD2BY1: remove dead code"
weslleyspereira Aug 5, 2022
2beef68
Fix documentation for double, complex and double complex
weslleyspereira Aug 5, 2022
2ba5e8e
Fix bug in DORCSD2BY1 (found by doing a diff between single and doubl…
weslleyspereira Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SRC/cunbdb2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is COMPLEX array, dimension (P)
*> TAUP1 is COMPLEX array, dimension (P-1)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
*>
*> \param[out] TAUP2
*> \verbatim
*> TAUP2 is COMPLEX array, dimension (M-P)
*> TAUP2 is COMPLEX array, dimension (Q)
*> The scalar factors of the elementary reflectors that define
*> P2.
*> \endverbatim
Expand Down
4 changes: 2 additions & 2 deletions SRC/cunbdb4.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,14 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is COMPLEX array, dimension (P)
*> TAUP1 is COMPLEX array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
*>
*> \param[out] TAUP2
*> \verbatim
*> TAUP2 is COMPLEX array, dimension (M-P)
*> TAUP2 is COMPLEX array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P2.
*> \endverbatim
Expand Down
4 changes: 2 additions & 2 deletions SRC/dorbdb2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is DOUBLE PRECISION array, dimension (P)
*> TAUP1 is DOUBLE PRECISION array, dimension (P-1)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
*>
*> \param[out] TAUP2
*> \verbatim
*> TAUP2 is DOUBLE PRECISION array, dimension (M-P)
*> TAUP2 is DOUBLE PRECISION array, dimension (Q)
*> The scalar factors of the elementary reflectors that define
*> P2.
*> \endverbatim
Expand Down
4 changes: 2 additions & 2 deletions SRC/dorbdb4.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,14 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is DOUBLE PRECISION array, dimension (P)
*> TAUP1 is DOUBLE PRECISION array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
*>
*> \param[out] TAUP2
*> \verbatim
*> TAUP2 is DOUBLE PRECISION array, dimension (M-P)
*> TAUP2 is DOUBLE PRECISION array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P2.
*> \endverbatim
Expand Down
6 changes: 3 additions & 3 deletions SRC/dorcsd2by1.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
* Simultaneously diagonalize X11 and X21.
*
CALL DBBCSD( JOBV1T, 'N', JOBU1, JOBU2, 'T', M, Q, P, THETA,
$ WORK(IPHI), V1T, LDV1T, DUM2, 1, U1, LDU1, U2,
$ WORK(IPHI), V1T, LDV1T, DUM1, 1, U1, LDU1, U2,
$ LDU2, WORK(IB11D), WORK(IB11E), WORK(IB12D),
$ WORK(IB12E), WORK(IB21D), WORK(IB21E),
$ WORK(IB22D), WORK(IB22E), WORK(IBBCSD), LBBCSD,
Expand Down Expand Up @@ -635,7 +635,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
* Simultaneously diagonalize X11 and X21.
*
CALL DBBCSD( 'N', JOBV1T, JOBU2, JOBU1, 'T', M, M-Q, M-P,
$ THETA, WORK(IPHI), DUM2, 1, V1T, LDV1T, U2,
$ THETA, WORK(IPHI), DUM1, 1, V1T, LDV1T, U2,
$ LDU2, U1, LDU1, WORK(IB11D), WORK(IB11E),
$ WORK(IB12D), WORK(IB12E), WORK(IB21D),
$ WORK(IB21E), WORK(IB22D), WORK(IB22E),
Expand Down Expand Up @@ -706,7 +706,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
* Simultaneously diagonalize X11 and X21.
*
CALL DBBCSD( JOBU2, JOBU1, 'N', JOBV1T, 'N', M, M-P, M-Q,
$ THETA, WORK(IPHI), U2, LDU2, U1, LDU1, DUM2,
$ THETA, WORK(IPHI), U2, LDU2, U1, LDU1, DUM1,
$ 1, V1T, LDV1T, WORK(IB11D), WORK(IB11E),
$ WORK(IB12D), WORK(IB12E), WORK(IB21D),
$ WORK(IB21E), WORK(IB22D), WORK(IB22E),
Expand Down
2 changes: 1 addition & 1 deletion SRC/sorbdb4.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is REAL array, dimension (P)
*> TAUP1 is REAL array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
Expand Down
5 changes: 4 additions & 1 deletion SRC/sorcsd2by1.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,10 +672,13 @@ SUBROUTINE SORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
* Accumulate Householder reflectors
*
IF( WANTU2 .AND. M-P .GT. 0 ) THEN
CALL SCOPY( M-Q, WORK(IORBDB+P), 1, U2, 1 )
CALL SCOPY( M-P, WORK(IORBDB+P), 1, U2, 1 )
END IF
IF( WANTU1 .AND. P .GT. 0 ) THEN
CALL SCOPY( P, WORK(IORBDB), 1, U1, 1 )
DO J = 2, P
U1(1,J) = ZERO
END DO
CALL SLACPY( 'L', P-1, M-Q-1, X11(2,1), LDX11, U1(2,2),
$ LDU1 )
CALL SORGQR( P, P, M-Q, U1, LDU1, WORK(ITAUP1),
Expand Down
4 changes: 2 additions & 2 deletions SRC/zunbdb2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is COMPLEX*16 array, dimension (P)
*> TAUP1 is COMPLEX*16 array, dimension (P-1)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
*>
*> \param[out] TAUP2
*> \verbatim
*> TAUP2 is COMPLEX*16 array, dimension (M-P)
*> TAUP2 is COMPLEX*16 array, dimension (Q)
*> The scalar factors of the elementary reflectors that define
*> P2.
*> \endverbatim
Expand Down
4 changes: 2 additions & 2 deletions SRC/zunbdb4.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,14 @@
*>
*> \param[out] TAUP1
*> \verbatim
*> TAUP1 is COMPLEX*16 array, dimension (P)
*> TAUP1 is COMPLEX*16 array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P1.
*> \endverbatim
*>
*> \param[out] TAUP2
*> \verbatim
*> TAUP2 is COMPLEX*16 array, dimension (M-P)
*> TAUP2 is COMPLEX*16 array, dimension (M-Q)
*> The scalar factors of the elementary reflectors that define
*> P2.
*> \endverbatim
Expand Down