Skip to content

Conversation

dklyuchinskiy
Copy link
Contributor

@dklyuchinskiy dklyuchinskiy commented Feb 14, 2023

Hello!

Please review.

Checklist

  • Added test for error exit sytd2
  • Added test for error exit gehd2
  • Extended error checks for sysv routines (aasen, 2stage)
  • Fixed typo in in zsysv_aa_2stage driver for error exit

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (7433177) compared to base (b1e25a3).
Patch has no changes to coverable lines.

❗ Current head 7433177 differs from pull request most recent head 56934c7. Consider uploading reports for the commit 56934c7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1908     1908           
  Lines      187072   187072           
=======================================
  Misses     187072   187072           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@angsch angsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

*
PATH( 1: 1 ) = 'Zomplex precision'
PATH( 2: 3 ) = 'H2'
PATH( 2: 3 ) = 'S2'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing spot!

*
SRNAMT = 'ZHESV_AA'
INFOT = 1
CALL ZHESV_AA( '/', 0, 0, A, 1, IP, B, 1, W, 1, INFO )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZHESV_AA and ZSYSV_AA_2STAGE are missing in the declaration list of external subroutines. The same holds for the 'C' precision.

@langou langou merged commit e860053 into Reference-LAPACK:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants