Skip to content

fix some DMD issues #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix some DMD issues #959

merged 2 commits into from
Dec 12, 2023

Conversation

dklyuchinskiy
Copy link
Contributor

@dklyuchinskiy dklyuchinskiy commented Dec 12, 2023 •
edited
Loading

fix some DMD issues

  1. add DMD tests into CMakeLists
  2. init variable SSUM before call of LASSQ to prevent error exit with info = -8 or info = -10

Related to #960.

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (c2255a8) 0.00% compared to head (4787915) 0.00%.

Files Patch % Lines
SRC/cgedmd.f90 0.00% 4 Missing ⚠️
SRC/dgedmd.f90 0.00% 4 Missing ⚠️
SRC/sgedmd.f90 0.00% 4 Missing ⚠️
SRC/zgedmd.f90 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1930     1930           
  Lines      190413   190421    +8     
=======================================
- Misses     190413   190421    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dklyuchinskiy dklyuchinskiy mentioned this pull request Dec 12, 2023
Open
4 tasks
@dklyuchinskiy dklyuchinskiy marked this pull request as ready for review December 12, 2023 08:14
@langou langou merged commit db501d9 into Reference-LAPACK:master Dec 12, 2023
@langou
Copy link
Contributor

langou commented Dec 12, 2023

Thanks @dklyuchinskiy. Good catch!

@grisuthedragon grisuthedragon mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langou langou langou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dklyuchinskiy @langou