{C,Z}LARFGP: re-scale input vector more often #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-scale the input vector even if `X` is negligibly small in norm if the imaginary part of `ALPHA` is nonzero. For otherwise `XNORM` will not be computed with a small _relative_ error. fixes Reference-LAPACK#980
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1930 1930
Lines 190421 190409 -12
=======================================
+ Misses 190421 190409 -12 ☔ View full report in Codecov by Sentry. |
langou
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-scale the input vector even if
Xis negligibly small in norm if the imaginary part ofALPHAis nonzero. For otherwiseXNORMwill not be computed with a small relative error.Checklist