Two small fixes of bdsqr #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Reference-LAPACK#234 only dbdsqr was updated. This updates the documentation of the other precisions.
[D,Z]BDSQR returns for D = [ -4.0, -3.0, -2.0, -1.0, 0.0, 1.0, 2.0, 3.0, 4.0, 5.0] E = [ 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0] as singular value D(10) = -ZERO. By definition, singular values are non-negative. LASQ1 already fixes the sign and returns +ZERO.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1929 1929
Lines 190627 190635 +8
=======================================
- Misses 190627 190635 +8 ☔ View full report in Codecov by Sentry. |
|
I approve of this change. However, @langou and I were recently discussing something similar about -ZERO and ZERO. Since we cannot normally distinguish between the two, for example:
However, |
langou
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes of bdsqr:
In Update dbdsqr.f #234 only the documentation of
dbdsqrwas updated. This updates the documentation of the remaining precisions.bdsqrcan return-ZEROas a singular value. For example,[d,z]bdsqronreturns
D(10) = -ZERO. This adds a branch enforcing that all singular values follow the definition and are non-negative, i.e.,-ZEROis converted into+ZERO. Note that this is already enforced inlasq1(used for the singular-values-only path).