Skip to content

fix(smart-contracts): update batch fees #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2022
Merged

fix(smart-contracts): update batch fees #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72bbf2d
update batch fees from 1% to .3%
olivier7delf Jun 29, 2022
207ba00
Merge branch 'master' into fix/update-batch-fees
olivier7delf Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/smart-contracts/scripts-create2/contract-setup/adminTasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { BigNumber } from 'ethers';

// Fees: 0.5%
export const REQUEST_SWAP_FEES = 5;
// Batch Fees: 1%
export const BATCH_FEE = 10;
// Batch Fees: .3%
export const BATCH_FEE = 3;

export const updateChainlinkConversionPath = async (
contract: any,
Expand Down Expand Up @@ -57,6 +57,8 @@ export const updateBatchPaymentFees = async (
): Promise<void> => {
const currentFees = await contract.batchFee();
if (currentFees !== BATCH_FEE) {
// Log is useful to have a direct view on was is being updated
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Log is useful to have a direct view on was is being updated
// Log is useful to have a direct view on what is being updated

console.log(`currentFees: ${currentFees.toString()}, new fees: ${BATCH_FEE}`);
Copy link
Contributor

@bertux bertux Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be displayed by dividing it by 10 ?

await contract.setBatchFee(BATCH_FEE, { nonce: nonce, gasPrice: gasPrice });
}
};
Expand Down
6 changes: 3 additions & 3 deletions packages/smart-contracts/scripts-create2/contract-setup/setupBatchPayments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ export const setupBatchPayments = async (

// start from the adminNonce, increase gasPrice if needed
await Promise.all([
updateBatchPaymentFees(batchPaymentConnected, adminNonce, gasPrice),
updatePaymentErc20FeeProxy(batchPaymentConnected, network, adminNonce + 1, gasPrice),
updatePaymentEthFeeProxy(batchPaymentConnected, network, adminNonce + 2, gasPrice),
updateBatchPaymentFees(batchPaymentConnected, adminNonce, gasPrice.mul(2)),
updatePaymentErc20FeeProxy(batchPaymentConnected, network, adminNonce + 1, gasPrice.mul(2)),
updatePaymentEthFeeProxy(batchPaymentConnected, network, adminNonce + 2, gasPrice.mul(2)),
]);
}),
);
Expand Down